Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): porting code from pr_758 to improve code #11 #870

Merged
merged 2 commits into from
Nov 2, 2022
Merged

feat(tianmu): porting code from pr_758 to improve code #11 #870

merged 2 commits into from
Nov 2, 2022

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Nov 1, 2022 •
edited
Loading

Summary about this PR

[summary]

NULL-->nullptr
namespace "DBHandler"-->"handler"
class TianmuHandler-->ha_tianmu
sdb-->tianmu
functions in ha_my_tianmu.cpp all renamed with prefix "ha_my_tianmu_xxx"
Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Nov 1, 2022
@hustjieke
feat(tianmu): porting code from pr_758 to improve code stoneatom#11
33f05fd 
[summary]

NULL-->nullptr
namespace "DBHandler"-->"handler"
class TianmuHandler-->ha_tianmu
sdb-->tianmu
functions in ha_my_tianmu.cpp all renamed with prefix "ha_my_tianmu_xxx"
@hustjieke hustjieke force-pushed the feat_porting_code_releated_pr_758 branch from d59e0de to 33f05fd Compare November 1, 2022 11:57
@hustjieke hustjieke marked this pull request as ready for review November 1, 2022 12:56
lujiashun
lujiashun approved these changes Nov 2, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC
RingsC approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 8a28e28 into stoneatom:stonedb-5.7-dev Nov 2, 2022
@Nliver Nliver added this to the StoneDB_5.7_v1.0.2 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@zsp108 zsp108 zsp108 approved these changes

@RingsC RingsC RingsC approved these changes

@adofsauron adofsauron Awaiting requested review from adofsauron

@DandreChen DandreChen Awaiting requested review from DandreChen

Assignees

@hustjieke hustjieke

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.2
Development

Successfully merging this pull request may close these issues.
5 participants
@hustjieke @RingsC @zsp108 @lujiashun @Nliver